Bug report and patch for SQLGetConnectAttr.c

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Bug report and patch for SQLGetConnectAttr.c

Matt Grimm
Hello,

I found a bug in SQLGetConnectAttr.c that makes it impossible to tell if tracing is disabled. When tracing is explicitly disabled with SQLSetConnectAttr(), SQLGetConnectAttr() still returns SQL_OPT_TRACE_ON.

I've attached a patch to the 2.3.2 release that fixes the issue for me. If the change is acceptable, would you also consider backporting it to 2.3.1?

Thanks,
m.

_______________________________________________
unixODBC-dev mailing list
[hidden email]
http://mailman.unixodbc.org/mailman/listinfo/unixodbc-dev

trace_attr_patch.txt (614 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug report and patch for SQLGetConnectAttr.c

Nick Gorham-2
On 04/11/13 21:06, Matt Grimm wrote:
> Hello,
>
> I found a bug in SQLGetConnectAttr.c that makes it impossible to tell
> if tracing is disabled. When tracing is explicitly disabled with
> SQLSetConnectAttr(), SQLGetConnectAttr() still returns SQL_OPT_TRACE_ON.

Thanks.
>
> I've attached a patch to the 2.3.2 release that fixes the issue for
> me. If the change is acceptable, would you also consider backporting
> it to 2.3.1?

I will do you a 2.3.1-1 tarball if that helps with the change in.

--
nick
_______________________________________________
unixODBC-dev mailing list
[hidden email]
http://mailman.unixodbc.org/mailman/listinfo/unixodbc-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug report and patch for SQLGetConnectAttr.c

Matt Grimm
On Mon, Nov 4, 2013 at 3:45 PM, Nick Gorham <[hidden email]> wrote:
I've attached a patch to the 2.3.2 release that fixes the issue for me. If the change is acceptable, would you also consider backporting it to 2.3.1?

I will do you a 2.3.1-1 tarball if that helps with the change in.
 
Sure, much appreciated!

m.

_______________________________________________
unixODBC-dev mailing list
[hidden email]
http://mailman.unixodbc.org/mailman/listinfo/unixodbc-dev
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Bug report and patch for SQLGetConnectAttr.c

Nick Gorham-2
On 05/11/13 14:28, Matt Grimm wrote:
On Mon, Nov 4, 2013 at 3:45 PM, Nick Gorham <[hidden email]> wrote:
I've attached a patch to the 2.3.2 release that fixes the issue for me. If the change is acceptable, would you also consider backporting it to 2.3.1?

I will do you a 2.3.1-1 tarball if that helps with the change in.
 
Sure, much appreciated!

Its checked in, and there should be a 2.2.1-1 file on the ftp site.

--
Nick

_______________________________________________
unixODBC-dev mailing list
[hidden email]
http://mailman.unixodbc.org/mailman/listinfo/unixodbc-dev
Loading...